-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hibernate-search] Re-enable lazy loading #6199
Closed
matthias-ronge
wants to merge
110
commits into
kitodo:hibernate-search
from
matthias-ronge:5760_1c_4
Closed
[hibernate-search] Re-enable lazy loading #6199
matthias-ronge
wants to merge
110
commits into
kitodo:hibernate-search
from
matthias-ronge:5760_1c_4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From FindBugs. SimpleDateFormat class is not thread-safe. Using an object across threads may result in undefined behavior.
This is done in anticipation of the upcoming renaming of the X packages.
This also considers non-empty strings that consist of white space only as empty, which, as far as I can see, is the more correct choice in all places.
Fixes error: ELException: Fehler beim Lesen von canBeUsedForProcess für den Typ Template, caused by LazyInitializationException: failed to lazily initialize collection tasks, could not initialize proxy - no Session Rationale: number of task per template is small
The test exits with an ElementClickInterceptedException: "element click intercepted: Element <h3 id="headerText">...</h3> is not clickable at point (321, 96). Other element would receive the click: <div id="loadingScreen" style="">...</div>". It is not clear why the error occurs, the loading screen is not visible in my Chrome at that moment. Since the problem seems unrelated to the current development, this test is temporarily disabled.
matthias-ronge
force-pushed
the
5760_1c_4
branch
from
August 29, 2024 13:44
b2be7c4
to
0e8cfbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5760 1c) -- part 4
In this part, lazy loading for processes in projects, and for children of processes is put back into operation. The solution was much simpler than I had originally planned, using Hibernate annotations. It does not require the view objects discussed previously.
Follow-up pull request to #6085 (immediate diff)