Fix wrong checks of empty string in LdapUser context #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solth
requested changes
Sep 2, 2024
use dedicated, negated check instead of manually negating positive check Co-authored-by: Arved Solth <[email protected]>
solth
approved these changes
Sep 2, 2024
|
@gerlingsm thank you for incorporating the change requests. Would you mind opening a corresponding bugfix branch against the 3.7.x branch? |
No problem, I have opened a corresponding pull request #6217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following commit ".isEmpty()" was replaced with "StringUtils.isBlank".
But unfortunately the negation of the calls has been lost which is why they are now testing the opposite of what they should.
This merge request should fix the error.
fix #6210