Fix the disappearance of collapsed metadata #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartChris
force-pushed
the
fix_collapsed_metadata
branch
from
6922ecc
to
13fe109
Compare
|
@BartChris Please rebase against current master to avoid failing builds caused by broken Selenium tests! |
BartChris
force-pushed
the
fix_collapsed_metadata
branch
from
13fe109
to
7011646
Compare
solth
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@BartChris it seems you found the best variation of the solution, now. It does indeed fix the nasty bug in the editor without having any side effects on the import mask. Thanks a lot for this - evolved! - fix!
|
@BartChris would you mind opening a corresponding fix pull request for the 3.7 branch? |
|
Sure #6246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced version of #6232
Fixes #6231
@solth I followed your suggestion to only "activate" the ajax tag in the metadata editor by using the onstart functionality for checking a passed in context value, which makes it possible to decide what the rendering context is.
Edit: I can probably inspect the URI directly to not having to introduce an addional renderContext.