Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile time optimizations #379

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Compile time optimizations #379

merged 2 commits into from
Oct 23, 2023

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Oct 19, 2023

Based on the report @zeerooth submitted, I got rid of the newer ring dependency (which, for some reason, has a build script that runs for a long time) and got rid of the zstd dependency, which also takes a long time to compile native dependencies.

@zeerooth
Copy link
Collaborator

Looks pretty good, a minute shaved off!

isolang is still the biggest offender (well, and diesel and async-graphql to a degree)

image

cargo-timing-20231019T125507Z.html.txt

@aumetra
Copy link
Member Author

aumetra commented Oct 22, 2023

I just rechecked on my laptop and apparently the newest ring has a build script that only takes 9s on my laptop.
Therefore I'm opting for keeping ring at the newest version, like before.

@aumetra aumetra marked this pull request as ready for review October 22, 2023 17:19
@aumetra aumetra requested a review from zeerooth October 22, 2023 17:20
@aumetra
Copy link
Member Author

aumetra commented Oct 22, 2023

(requesting one last run on your hardware, if you got the time @zeerooth)

@zeerooth
Copy link
Collaborator

@aumetra
Copy link
Member Author

aumetra commented Oct 23, 2023

@zeerooth okay, thanks for the run! I'd say that's in the acceptable range of variance.

Looking at the output, ring doesn't break the build times anymore and the additional time can be attributed to the new opentelemetry dependencies and to general compile time variance

@zeerooth
Copy link
Collaborator

Indeed, ring is not problematic anymore; out of the dependencies only isolang is the one that really takes a long time to compile, but we discussed that and there's really nothing to improve there because of these repeated long language enums

@aumetra aumetra added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit e41c739 Oct 23, 2023
7 checks passed
@aumetra aumetra deleted the aumetra/compile-time-opts branch October 23, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants