-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile time optimizations #379
Conversation
Looks pretty good, a minute shaved off!
|
2c0883f
to
c088272
Compare
I just rechecked on my laptop and apparently the newest |
(requesting one last run on your hardware, if you got the time @zeerooth) |
@aumetra 3m 54s now |
@zeerooth okay, thanks for the run! I'd say that's in the acceptable range of variance. Looking at the output, ring doesn't break the build times anymore and the additional time can be attributed to the new |
Indeed, ring is not problematic anymore; out of the dependencies only isolang is the one that really takes a long time to compile, but we discussed that and there's really nothing to improve there because of these repeated long language enums |
Based on the report @zeerooth submitted, I got rid of the newer
ring
dependency (which, for some reason, has a build script that runs for a long time) and got rid of thezstd
dependency, which also takes a long time to compile native dependencies.