Comma delimited info string language#328
Comma delimited info string language#328CosmicHorrorDev wants to merge 2 commits intokivikakk:mainfrom
Conversation
| ```\n\ | ||
| ", | ||
| "\ | ||
| <pre style=\"background-color:#2b303b;\"><code class=\"language-rust,ignore\">\ |
There was a problem hiding this comment.
This still has class="language-rust,ignore", so it wouldn't match anything looking for the class language-rust.
There was a problem hiding this comment.
I see now that this doesn't fit your use case. Changing that would differ from cmark-gfm's output, but I should be able to add that functionality behind a parse option instead
I'll work on handling that today
There was a problem hiding this comment.
It does match GitHub's behavior though, so maybe cmark-gfm has a bug 🤔
There was a problem hiding this comment.
My guess is that GitHub uses the full-info-string option (which gives the full info string, not just the first word) and then parses the language out themselves. That's what we do.
There was a problem hiding this comment.
I'm not sure on how to proceed, so I'll just be awaiting more definitive feedback
|
Merged with #752! |
4 participants
Fixes #246
Changes the syntect plugin to split off any text following a comma from the language tag to match what is supported by rustdoc and GitHub. This now accepts
```rust,no_runas Rust code