Skip to content

Fix kiwisolver recipe fatal error: 'Python.h' file not found #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreMiras merged 2 commits into from
Mar 7, 2025
Merged

Fix kiwisolver recipe fatal error: 'Python.h' file not found #3118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf019d
From https://github.com/kivy/python-for-android/issues/3115
mriscoc Mar 4, 2025
420df68
Merge branch 'kivy:develop' into Fix_KiwiSolver
mriscoc Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pythonforandroid/recipes/kiwisolver/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,13 @@ class KiwiSolverRecipe(PyProjectRecipe):
depends = ['cppy']
need_stl_shared = True

# from https://github.com/kivy/python-for-android/issues/3115
def get_recipe_env(self, arch, **kwargs):
env = super().get_recipe_env(arch, **kwargs)
flags = " -I" + self.ctx.python_recipe.include_root(arch.arch)
env["CFLAGS"] = flags
env["CPPFLAGS"] = flags
Comment on lines +15 to +16
Copy link
Member

@AndreMiras AndreMiras Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mriscoc I'm seeing this late, but why didn't we append the flags rather than overriding?

Copy link
Member

@T-Dynamos T-Dynamos Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that might be the reason macos runner might be failing. (Btw I am to blame for this)

Copy link
Member

@AndreMiras AndreMiras Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the recipe wasn't building anyway, so overall situation is better than the previous state.

return env


recipe = KiwiSolverRecipe()
Loading