♻️ Consolidate assemble_distribution() into base Bootstrap #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
force-pushed
the
feature/bootstraps_refactoring
branch
from
dc6fb4a to
5319a90
Compare
kuzeyron
approved these changes
Dec 7, 2025
Move duplicated assemble_distribution() logic from service_only, webview, and _sdl_common bootstraps into the base Bootstrap class using the Template Method pattern. - Add _assemble_distribution_for_arch() hook for per-arch customization - SDL bootstrap overrides hook to skip distribute_aars() - service_only and webview now use base class directly - Qt bootstrap unchanged (single-arch constraint requires full override) - Update tests to mock base class instead of individual modules
AndreMiras
force-pushed
the
feature/bootstraps_refactoring
branch
from
5319a90 to
1f4a567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move duplicated assemble_distribution() logic from service_only, webview, and _sdl_common bootstraps into the base Bootstrap class using the Template Method pattern.