Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an optional fix for right-to-left text #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlonTzarafi
Copy link

Rtl text was disordering the calendar cells between columns. Added a
setting to enable a fix.

The fix is made optional because it depends on a special unicode character (the "LEFT-TO-RIGHT EMBEDDING" character).

Rtl text was disordering the calendar cells between columns. Added a setting to enable a fix.

The fix is made optional because it depends on a special unicode character (the "LEFT-TO-RIGHT EMBEDDING" character).
@kiwanami
Copy link
Owner

kiwanami commented Dec 6, 2017

I'm sorry for my slow response.
Thank you for your PR!
Your code looks good for me, but I don't know how to check it because I have not used r2l function on emacs.
Will you tell me how to check?

@AlonTzarafi
Copy link
Author

AlonTzarafi commented Dec 6, 2017

Hi kiwanami. Thanks for checking out the PR.
The easiest way to see the problem is having a Hebrew calendar event and an English one after it.
Modern Emacs will display the Hebrew words, but the order will be garbled in the calendar view.
You can try it by launching the monthly calendar view, to display these two org-mode events:

** אירוע בעברית!
   SCHEDULED: <2017-12-13 Wed 12:00>
** English event!
   SCHEDULED: <2017-12-14 Thu 12:00>

Then, set the fix:
(setq cfw:fix-rtl-content t)
And refresh the calendar buffer.

@kiwanami
Copy link
Owner

Hi @AlonTzarafi
Thank you for advice on how to check.
I'll try soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants