org-create-file-source RECURING EVENT fix #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 29, 2022 04:53
Prior to this change, recurring events worked in org-create-source, but NOT in org-create-file-source. This is not the cleanest lisp code, because I am cookbooking my way through making something work and not properly understanding what I am doing, BUT org-create-file-source NOW handles recurring events correctly. Ideally, instead of making separate sets of functions for cfw:org-file-schedule-period-to-calendar and cfw:org-file-collect-schedules-period I should have made the "file" argument ":optional" (in both original functions) and handled both org-create-file-source and org-create-source through the same chain of cfw:org-schedule-period-to-calendar and cfw:org-file-collect-schedules-period ... My lisp skills were not up to completing that approach CLEANLY, so I have done things this way.
|
This includes changes made in #144 |
|
Closing this in favor of #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recurring events in single-org-file sources
Prior to this change, recurring events worked
in org-create-source, but NOT in org-create-file-source.
This is not the cleanest lisp code, because I am
cookbooking my way through making something work
and not properly understanding what I am doing,
BUT org-create-file-source NOW handles recurring
events correctly.
Ideally, instead of making separate sets of functions for
cfw:org-file-schedule-period-to-calendar and
cfw:org-file-collect-schedules-period
I should have made the "file" argument ":optional"
(in both original functions) and handled both
org-create-file-source and org-create-source
through the same chain of
cfw:org-schedule-period-to-calendar and
cfw:org-file-collect-schedules-period
... My lisp skills were not up to completing
that approach CLEANLY, so I have done things this way.