Feat: Add a variable to control whether face-today is applied #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable gives the user control on whether `cfw:face-today` is applied to the whole day view or not. The default value `t` ensures that existing behaviour is not affected. I use `emacs-calfw` in Day view mode, and I do not want the `cfw:face-today` background in Day View. I wouldn't mind it in Week View. Hiding the application of the face behind a variable gives me the control I prefer.
vedang
added a commit
to vedang/calfw-blocks
that referenced
this pull request
Jan 21, 2023
This variable gives me control on whether `cfw:face-today` is applied to the whole day view or not. This is important because I actually prefer the colors that `calfw-blocks` uses for rendering the calendar than the default used by `emacs-calfw`, and setting the new `cfw:hightlight-today` to nil lets me use it so. This change has also been contributed back to `emacs-calfw` at: kiwanami/emacs-calfw#154
vedang
added a commit
to vedang/calfw-blocks
that referenced
this pull request
Jan 21, 2023
This variable gives me control on whether `cfw:face-today` is applied to the whole day view or not. This is important because I actually prefer the colors that `calfw-blocks` uses for rendering the calendar than the default used by `emacs-calfw`, and setting the new `cfw:hightlight-today` to nil lets me use it so. This change has also been contributed back to `emacs-calfw` at: kiwanami/emacs-calfw#154
vedang
added a commit
to vedang/emacs-up
that referenced
this pull request
Jan 23, 2023
Visually looking at the day gives a far more visceral understanding of what you plan to do today. Note that I am using personal recipes for both these projects, until the fixes I've made can be merged upstream. The relevant PRs are: - kiwanami/emacs-calfw#154 - kiwanami/emacs-calfw#155 - ml729/calfw-blocks#1 - ml729/calfw-blocks#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new variable
cfw:highlight-todaygives the user control on whethercfw:face-todayis applied to the whole day view or not. The default valuetensures that existing behaviour is not affected.I use
emacs-calfwin Day view mode, and I do not want thecfw:face-todaybackground in Day View. I wouldn't mind it in Week View. Hiding the application of the face behind a variable gives me the control I prefer.