Fix wrong-number-of-arguments error #59
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Emacs 28 I'm seeing the following error when running the tests.
I believe this is because the
start-process-shell-command
functionis called with the command arguments as &rest parameters. This is the
function signature of
start-process-shell-command
, and it only takes3 arguments, the name, buffer, and command. The command argument can
be a shell string like "ls -l" for example.
The
start-process
function on the other hand has &rest parametersand can be called with a list of arguments.
This PR fixes the issue by concatenating the command and it's argument
before calling out to
deferred:process-buffer-gen
, which is used inboth cases, when calling
start-process-shell-command
, and whencalling
start-process
.