Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Update docs and examples about local setup #198

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Update docs and examples about local setup #198

merged 1 commit into from
Oct 31, 2019

Conversation

m1n0
Copy link

@m1n0 m1n0 commented Oct 9, 2019

Some small updates to docs.

@m1n0 m1n0 force-pushed the mlukac/update-docs branch from d0e19b9 to dfec181 Compare October 10, 2019 07:03
paveldedik
paveldedik suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@paveldedik paveldedik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! Please, check the comments :-)

.env.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@m1n0 m1n0 mentioned this pull request Oct 21, 2019
Open
m1n0
m1n0 commented Oct 21, 2019
View reviewed changes
Copy link
Author

@m1n0 m1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and created an issue.

.env.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
paveldedik
paveldedik reviewed Oct 21, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
paveldedik
paveldedik reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@paveldedik paveldedik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just fix the coala issue, and you can also squash the commits into one while doing that :-)

README.md Outdated Show resolved Hide resolved
paveldedik
paveldedik suggested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@paveldedik paveldedik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one and fix the Shortlog of the HEAD commit contains 87 character(s). This is 15 character(s) longer than the limit (87 > 72) issue reported by coala.

@m1n0 m1n0 force-pushed the mlukac/update-docs branch from b837d03 to 81280ad Compare October 30, 2019 13:56
@aexvir aexvir force-pushed the mlukac/update-docs branch from 81280ad to c395c34 Compare October 30, 2019 16:52
@m1n0 m1n0 force-pushed the mlukac/update-docs branch from c395c34 to 87473e7 Compare October 31, 2019 07:20
@m1n0
Copy link
Author

m1n0 commented Oct 31, 2019

Updated and squashed

@paveldedik
Copy link
Contributor

Thank you!

@paveldedik paveldedik merged commit 51cfc2c into master Oct 31, 2019
@paveldedik paveldedik deleted the mlukac/update-docs branch October 31, 2019 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aexvir aexvir aexvir left review comments

@paveldedik paveldedik paveldedik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1n0 @paveldedik @aexvir