Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ability to ignore requests on initial "ADDED" events #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Introduce ability to ignore requests on initial "ADDED" events #217

wants to merge 2 commits into from

Conversation

pkosiec
Copy link

@pkosiec pkosiec commented Sep 27, 2022 •
edited
Loading

Resolves #216.

Let me know what you think!

@pkosiec pkosiec changed the title Introduce ability to ignore requests on "ADDED" events Introduce ability to ignore requests on initial "ADDED" events Sep 27, 2022
This was referenced Sep 28, 2022
Closed
Merged
jekkel
jekkel requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@jekkel jekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs some small changes.

Furthermore, can you potentially write a small test scenario? This would involve:

  • adjusting ./test/server/server.py to be able to identify whether a call has been made
  • adjust ./test/resources/sidecar.yaml to configure a new sidecar instance or reconfigure an existing one to skip the request
  • in the github test workflow add appropriate file downloads and verification.

src/resources.py Outdated Show resolved Hide resolved
src/resources.py Outdated Show resolved Hide resolved
src/resources.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pkosiec
Copy link
Author

pkosiec commented Sep 30, 2022

Hi @jekkel, thank you for review! I applied changes to the app and tested that locally. Now it should work as expected for the batched items as well.

When it comes to the integration tests, would you be able to help me with that? Unfortunately, I'm not fluent in Python and that would be difficult for me. Thank you in advance 🙇

@pkosiec
Copy link
Author

pkosiec commented Oct 20, 2022

Hey @jekkel, could you please take a look at this PR once again? Thank you!

@jekkel
Copy link
Member

jekkel commented Nov 7, 2022

When it comes to the integration tests, would you be able to help me with that? Unfortunately, I'm not fluent in Python and that would be difficult for me. Thank you in advance

Most of the test logic is bash anyway.

@github-actions github-actions bot added the stale close issues and PRs after 60 days of inactivity label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jekkel jekkel jekkel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
stale close issues and PRs after 60 days of inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to skip HTTP requests on initial "ADDED" events
2 participants
@pkosiec @jekkel