1.5.10

- `SettingType` fix `extends` param if `null`
kiwilan · Jun 29, 2023 · 7bc8a5e · 7bc8a5e
1 parent da75afd
commit 7bc8a5e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "kiwilan/typescriptable-laravel",
   "description": "PHP package for Laravel to type Eloquent models and routes with autogenerated TypeScript, ready for Inertia with associated NPM package.",
-  "version": "1.5.0",
+  "version": "1.5.10",
   "keywords": [
     "kiwilan",
     "laravel",

diff --git a/src/Typed/SettingType.php b/src/Typed/SettingType.php
@@ -18,17 +18,22 @@ protected function __construct(
     ) {
     }
 
-    public static function make(?string $settingsPath, ?string $outputPath, string $extends = 'Spatie\LaravelSettings\Settings'): self
+    public static function make(?string $settingsPath, ?string $outputPath, ?string $extends): self
     {
         if (! $settingsPath) {
             $settingsPath = TypescriptableConfig::settingsDirectory();
         }
 
         $tsFilename = TypescriptableConfig::settingsFilename();
+
         if (! $outputPath) {
             $outputPath = TypescriptableConfig::setPath();
         }
 
+        if (! $extends) {
+            $extends = 'Spatie\LaravelSettings\Settings';
+        }
+
         $items = ClassItem::list($settingsPath, TypescriptableConfig::settingsSkip());
         $items = array_filter($items, fn (ClassItem $item) => $item->extends === $extends);