Skip to content

Updated the README file to reflect the compatible version of Android Studio. #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 3, 2025
Merged

Updated the README file to reflect the compatible version of Android Studio. #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8204b85
Updated the `README` file to reflect the compatible version of Androi…
MohitMaliDeveloper Aug 30, 2025
05577a1
Fixed: `DefaultUncaughtExceptionDelegation` lint error.
MohitMaliDeveloper Sep 2, 2025
6f9a481
Fixed: `testPreviouslyLoadedArticleLoadsAgainWhenSwitchingToAnotherSc…
MohitMaliDeveloper Sep 2, 2025
4c067af
Updated the `README` file to reflect the compatible version of Androi…
MohitMaliDeveloper Aug 30, 2025
06b66cc
Fixed: `DefaultUncaughtExceptionDelegation` lint error.
MohitMaliDeveloper Sep 2, 2025
1824390
Merge remote-tracking branch 'origin/update_readme_file_for_android_s…
MohitMaliDeveloper Sep 3, 2025
f8a3396
Improved the saving of `tabs` history.
MohitMaliDeveloper Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Kiwix requires the following permissions to fully work:

## Build instructions
1. Clone [this repository](https://github.com/kiwix/kiwix-android).
2. Import the project with [Android Studio Narwhal Canary build](https://developer.android.com/studio/preview).
2. Import the project with [Android Studio](https://developer.android.com/studio).
3. Set the Gradle JDK to Java 17.
4. Run ./gradlew build from the root directory.

Expand Down
7 changes: 3 additions & 4 deletions core/src/main/java/org/kiwix/kiwixmobile/core/main/reader/CoreReaderFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2232,10 +2232,6 @@ abstract class CoreReaderFragment :
private fun saveTabStates(onComplete: () -> Unit = {}) {
CoroutineScope(Dispatchers.Main).launch {
savingTabsMutex.withLock {
// clear the previous history saved in database
withContext(Dispatchers.IO) {
repositoryActions?.clearWebViewPageHistory()
}
val coreApp = sharedPreferenceUtil?.context as CoreApp
val settings = coreApp.getSharedPreferences(
SharedPreferenceUtil.PREF_KIWIX_MOBILE,
Expand All @@ -2247,6 +2243,9 @@ abstract class CoreReaderFragment :
getWebViewHistoryEntity(view, index)?.let(webViewHistoryEntityList::add)
}
withContext(Dispatchers.IO) {
// clear the previous history saved in database
repositoryActions?.clearWebViewPageHistory()
// Store new history in database.
repositoryActions?.saveWebViewPageHistory(webViewHistoryEntityList)
}
settings.edit {
Expand Down
2 changes: 2 additions & 0 deletions ...rc/androidTest/java/org/kiwix/kiwixmobile/custom/search/SearchFragmentTestForCustomApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,9 @@ class SearchFragmentTestForCustomApp {
clickOnHomeButton(composeTestRule)
// click on an article to load the other page.
clickOnAFoolForYouArticle(composeTestRule)
composeTestRule.mainClock.advanceTimeByFrame()
assertAFoolForYouArticleLoaded(composeTestRule)
composeTestRule.waitUntilTimeout()
// open note screen.
openNoteFragment(customMainActivity as CoreMainActivity, composeTestRule)
composeTestRule.waitUntilTimeout()
Expand Down