Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate entry from search results #979

Conversation

HiroyasuNishiyama
Copy link
Contributor

The search results sometimes contain two identical entries, one with the snippet and another without it.
This is because index search results and title search results are treated separately.
This PR attempts to remove the duplicate results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.16%. Comparing base (9093134) to head (04f73e6).

Files with missing lines Patch % Lines
SwiftUI/Model/SearchOperation/SearchOperation.mm 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   37.23%   37.16%   -0.08%     
==========================================
  Files         111      111              
  Lines        6346     6358      +12     
==========================================
  Hits         2363     2363              
- Misses       3983     3995      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BPerlakiH
Copy link
Collaborator

Thank you @HiroyasuNishiyama for bringing this up. I am looking into it, how it could be handled the most performant way.

@BPerlakiH
Copy link
Collaborator

@HiroyasuNishiyama Please see my proposition of solving this here: #981

@kelson42
Copy link
Contributor

Superseeded by #981

@kelson42 kelson42 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants