Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works done
Video explanation
dailyscrum/packages/ui/vite.config.ts
Lines 8 to 31 in 3a0870f
import { Button } from 'ui'
in the server component triggers an error even when the Button component is not a client component but the bundle includes another client component.import { Button } from 'ui/shadcn-ui/button
making sure only the button component is imported. So it doesn't trigger a nextjs client component error.dailyscrum/packages/ui/package.json
Lines 4 to 14 in 016de5a
ui/button
,ui/shadcn-ui/accordion
"ui": "workspace:*"
in the dailyscrum app.dailyscrum/apps/dailyscrum/package.json
Line 15 in fdda0c1
workspace:*
setup, the ui package in the monorepo is linked into node_modules instead of downloading it from the npm registry.dailyscrum/apps/dailyscrum/src/app/layout.tsx
Line 4 in fdda0c1
dailyscrum/apps/dailyscrum/src/app/samples/page.tsx
Lines 1 to 39 in fdda0c1
dailyscrum/nx.json
Lines 1 to 10 in 016de5a
dailyscrum/packages/ui/src/components/button.tsx
Lines 6 to 10 in 3a0870f
dailyscrum/packages/ui/src/global.d.ts
Lines 3 to 21 in 3a0870f
Resolve #3