Add effect speed to configuration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kizza
force-pushed
the
add-effect-speed
branch
from
4a43700
to
a1f7f29
Compare
It seems we cannot adjust the effect speed after-the-fact, so need to include it here (for use amongst the service call) This commit also introduced a small `default` config data structure (as existing uses won't have this value by default)
kizza
force-pushed
the
add-effect-speed
branch
2 times, most recently
from
5df0a37
to
fe11a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1 it turns out the effect speed cannot be set individually on flux lights ad-hoc - but rather needs to be included within the set_custom_effect call.
This PR includes the new
speedconfig via a<ha-selector...