Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump katana #100

Merged
merged 6 commits into from
Sep 19, 2023
Merged

feat: bump katana #100

merged 6 commits into from
Sep 19, 2023

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Sep 13, 2023 •
edited
Loading

Bump the Katana dep and RPC deps.

Time spent on this PR: 2 days

Resolves: #NA

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

The katana dep and RPC dep is bumped.

Does this introduce a breaking change?

  • Yes
  • No

@greged93 greged93 marked this pull request as draft September 13, 2023 10:16
@greged93 greged93 marked this pull request as ready for review September 19, 2023 02:08
jobez
jobez reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jobez jobez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smol asks, the finish line approaches 🏃‍♂️

crates/ef-testing/src/models/case.rs Show resolved Hide resolved
crates/ef-testing/src/models/case.rs Outdated Show resolved Hide resolved
Eikix
Eikix reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR! Lfg let's get those ef-tests rekt

Eikix
Eikix approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Sep 19, 2023
Merged via the queue into kkrt-labs:main with commit 574efea Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobez jobez jobez left review comments

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greged93 @jobez @Eikix