-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more refactoring around Felt
#730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too much into replacing Felt::from
into into()
, I don't think it brings much and removes some readability in the code
@greged93 In fact my objective was to depend as little as possible on the word So I reverted the changes to keep this readability but I kept the main refactor that I wanted to carry out at the start of this PR if you agree with this one. |
Pull Request type
Time spent on this PR:
Resolves: #{Issue number}
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?