Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more refactoring around Felt #730

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

tcoratger
Copy link
Contributor

Pull Request type

Time spent on this PR:

Resolves: #{Issue number}

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@tcoratger tcoratger enabled auto-merge July 19, 2024 09:23
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too much into replacing Felt::from into into(), I don't think it brings much and removes some readability in the code

crates/ef-testing/src/evm_sequencer/evm_state/v0.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/evm_sequencer/evm_state/v1.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/evm_sequencer/evm_state/v1.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/evm_sequencer/sequencer/v0.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/evm_sequencer/sequencer/v1.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/evm_sequencer/utils.rs Outdated Show resolved Hide resolved
crates/sequencer/src/state.rs Outdated Show resolved Hide resolved
@tcoratger
Copy link
Contributor Author

I'm not too much into replacing Felt::from into into(), I don't think it brings much and removes some readability in the code

@greged93 In fact my objective was to depend as little as possible on the word Felt because it can change, etc. depending on updates and with into the inference is automatic. But you're right, it limits readability.

So I reverted the changes to keep this readability but I kept the main refactor that I wanted to carry out at the start of this PR if you agree with this one.

@tcoratger tcoratger added this pull request to the merge queue Jul 22, 2024
Merged via the queue into kkrt-labs:main with commit 6d57cfd Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants