Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tx gas available in transactions #757

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 16, 2024

Pull Request type

The execution of a transaction is bounded by two constraints:

  • The amount of steps available in the environment - a hard limit that, if reached, will stop the execution ungracefully
  • The amount of gas (similar to EVM Gas) available in the environment - if reached, the execution will be stopped gracefully.

In the verisoned_constants.json file, we update the max steps limit, without updating the gas limit. This lead to tests that would fail because reaching an 'Out of gas' limit, different from a hard step limit.

Time spent on this PR:

Resolves: #{Issue number}

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@enitrat enitrat added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit c6a121b Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants