clippy: rm unused clippy allowances (#1471)

kkrt-labs · Oct 20, 2024 · ead6737 · ead6737
1 parent 3b713ff
commit ead6737
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 15 deletions.
diff --git a/src/eth_rpc/servers/alchemy_rpc.rs b/src/eth_rpc/servers/alchemy_rpc.rs
@@ -1,5 +1,3 @@
-#![allow(clippy::blocks_in_conditions)]
-
 use crate::{
     eth_rpc::api::alchemy_api::AlchemyApiServer,
     models::token::{TokenBalances, TokenMetadata},

diff --git a/src/eth_rpc/servers/debug_rpc.rs b/src/eth_rpc/servers/debug_rpc.rs
@@ -1,4 +1,3 @@
-#![allow(clippy::blocks_in_conditions)]
 use crate::{eth_rpc::api::debug_api::DebugApiServer, providers::debug_provider::DebugProvider};
 use alloy_primitives::{Bytes, B256};
 use alloy_rpc_types::{BlockId, BlockNumberOrTag, TransactionRequest};

diff --git a/src/eth_rpc/servers/eth_rpc.rs b/src/eth_rpc/servers/eth_rpc.rs
@@ -1,5 +1,3 @@
-#![allow(clippy::blocks_in_conditions)]
-
 use crate::{
     client::{EthClient, KakarotTransactions, TransactionHashProvider},
     eth_rpc::api::eth_api::EthApiServer,

diff --git a/src/eth_rpc/servers/trace_rpc.rs b/src/eth_rpc/servers/trace_rpc.rs
@@ -23,7 +23,6 @@ impl<P: EthereumProvider> TraceRpc<P> {
 #[async_trait]
 impl<P: EthereumProvider + Send + Sync + 'static> TraceApiServer for TraceRpc<P> {
     /// Returns the parity traces for the given block.
-    #[allow(clippy::blocks_in_conditions)]
     #[tracing::instrument(skip(self), err)]
     async fn trace_block(&self, block_id: BlockId) -> Result<Option<Vec<LocalizedTransactionTrace>>> {
         tracing::info!("Serving debug_traceBlock");

diff --git a/src/models/felt.rs b/src/models/felt.rs
@@ -18,7 +18,6 @@ impl From<Felt252Wrapper> for Felt {
     }
 }
 
-#[allow(clippy::fallible_impl_from)]
 impl From<Address> for Felt252Wrapper {
     fn from(address: Address) -> Self {
         Self(Felt::from_bytes_be_slice(address.as_slice()))

diff --git a/src/providers/eth_provider/database/ethereum.rs b/src/providers/eth_provider/database/ethereum.rs
@@ -1,4 +1,3 @@
-#![allow(clippy::blocks_in_conditions)]
 use super::{
     filter,
     filter::EthDatabaseFilterBuilder,

diff --git a/src/providers/eth_provider/database/state.rs b/src/providers/eth_provider/database/state.rs
@@ -13,7 +13,6 @@ pub struct EthCacheDatabase<P: EthereumProvider + Send + Sync>(pub CacheDB<EthDa
 
 /// Ethereum database type.
 #[derive(Debug, Clone)]
-#[allow(clippy::redundant_pub_crate)]
 pub struct EthDatabase<P: EthereumProvider + Send + Sync> {
     /// The Ethereum provider.
     provider: P,

diff --git a/src/test_utils/katana/genesis.rs b/src/test_utils/katana/genesis.rs
@@ -244,7 +244,7 @@ impl KatanaGenesisBuilder<Loaded> {
 impl KatanaGenesisBuilder<Initialized> {
     /// Add an EOA to the genesis. The EOA is deployed to the address derived from the given private key.
     pub fn with_eoa(mut self, private_key: B256) -> Result<Self> {
-        let evm_address = self.evm_address(private_key)?;
+        let evm_address = Self::evm_address(private_key)?;
 
         let kakarot_address = self.cache_load("kakarot_address")?;
         let account_contract_class_hash = self.account_contract_class_hash()?;
@@ -295,7 +295,7 @@ impl KatanaGenesisBuilder<Initialized> {
     /// Fund the starknet address deployed for the evm address of the passed private key
     /// with the given amount of tokens.
     pub fn fund(mut self, pk: B256, amount: U256) -> Result<Self> {
-        let evm_address = self.evm_address(pk)?;
+        let evm_address = Self::evm_address(pk)?;
         let starknet_address = self.compute_starknet_address(evm_address)?;
         let eoa = self.contracts.get_mut(&starknet_address).ok_or_eyre("Missing EOA contract")?;
 
@@ -349,8 +349,7 @@ impl KatanaGenesisBuilder<Initialized> {
         )))
     }
 
-    #[allow(clippy::unused_self)]
-    fn evm_address(&self, pk: B256) -> Result<Felt> {
+    fn evm_address(pk: B256) -> Result<Felt> {
         Ok(Felt::from_bytes_be_slice(&PrivateKeySigner::from_bytes(&pk)?.address().into_array()))
     }
 

diff --git a/src/test_utils/katana/mod.rs b/src/test_utils/katana/mod.rs
@@ -232,7 +232,6 @@ impl<'a> Katana {
         &self.eoa
     }
 
-    #[allow(dead_code)]
     pub const fn sequencer(&self) -> &TestSequencer {
         &self.sequencer
     }

diff --git a/src/test_utils/rpc/mod.rs b/src/test_utils/rpc/mod.rs
@@ -54,7 +54,6 @@ use std::net::SocketAddr;
 ///
 /// `allow(dead_code)` is used because this function is used in tests,
 /// and each test is compiled separately, so the compiler thinks this function is unused
-#[allow(dead_code)]
 pub async fn start_kakarot_rpc_server(katana: &Katana) -> Result<(SocketAddr, ServerHandle), eyre::Report> {
     let eth_client = katana.eth_client();
     Ok(run_server(