Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer refactoring: Constants #1396

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Indexer refactoring: Constants #1396

merged 10 commits into from
Oct 29, 2024

Conversation

eugypalu
Copy link
Contributor

@eugypalu eugypalu commented Sep 20, 2024 •
edited
Loading

Resolves: #1394

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

  • Typed the constants in the file constants.ts
  • Moved the constants config, DEFAULT_BLOCK_GAS_LIMIT and IGNORED_KEYS to constants.ts

Does this introduce a breaking change?

  • Yes
  • No

greged93
greged93 suggested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I want to wait the reactivation of hive before merging any unneeded changes.

ClementWalter
ClementWalter previously approved these changes Sep 23, 2024
View reviewed changes
tcoratger
tcoratger previously approved these changes Sep 23, 2024
View reviewed changes
@greged93
Copy link
Contributor

hey @eugypalu couple of conflicts here, can you fix them?

@eugypalu eugypalu dismissed stale reviews from tcoratger and ClementWalter via 31c1696 September 27, 2024 15:22
@eugypalu eugypalu force-pushed the indexer_refactoring_constants branch 3 times, most recently from 696f4e1 to b74fbad Compare October 1, 2024 15:06
@greged93 greged93 force-pushed the indexer_refactoring_constants branch from b74fbad to 5d60a0f Compare October 4, 2024 07:17
@eugypalu eugypalu force-pushed the indexer_refactoring_constants branch from 5d60a0f to e8a5d0a Compare October 8, 2024 13:21
@eugypalu eugypalu force-pushed the indexer_refactoring_constants branch from e8a5d0a to 960ee93 Compare October 21, 2024 07:29
@eugypalu eugypalu force-pushed the indexer_refactoring_constants branch from 960ee93 to 752881b Compare October 22, 2024 10:35
@greged93 greged93 merged commit 2c468f5 into kkrt-labs:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

@tcoratger tcoratger tcoratger left review comments

@ClementWalter ClementWalter ClementWalter left review comments

@Eikix Eikix Awaiting requested review from Eikix Eikix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indexer refactoring: Constants [2]
4 participants
@eugypalu @greged93 @ClementWalter @tcoratger