Small improvements #1503
Open
Small improvements #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle_error function ensures any error stops execution and logs where it occurred. -retries for Katana: A retries count limits the wait loop for Katana to avoid infinite loops. -function Modularity: Each step is encapsulated in its own function, making the script modular and improving readability. -values are exported from manifest.json using environment variables, making the script adaptable to different environments.
for cleaner logs, use --quiet while updating the system
installing all required system dependencies (libclang-dev, libssl-dev, ca-certificates, tini, curl) in the chef or builder stage to avoid multiple apt-get calls. Using cargo chef cook with caching can significantly improve build speed. Remove unnecessary files after apt-get installs to reduce image size.
tudorpintea999
requested review from
ClementWalter,
Eikix and
greged93
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I improved a bit rpc docker file and the start bash script , description available in the commits.
Hope this helps you , if you need any additional help I m here !
Thanks
Tudor.