Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump katana to v1.0.0-alpha.19 #1512

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

bump katana to v1.0.0-alpha.19 #1512

wants to merge 6 commits into from

Conversation

tcoratger
Copy link
Collaborator

No description provided.

greged93
greged93 reviewed Oct 29, 2024
View reviewed changes
docker/hive/Dockerfile
@@ -1,7 +1,7 @@
# trunk-ignore-all(terrascan/AC_DOCKER_0047)

# CairoVM Chain
FROM ghcr.io/dojoengine/dojo:v1.0.0-alpha.15 as katana
FROM ghcr.io/dojoengine/dojo:v1.0.0-alpha.19 as katana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check that this works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't checked yet but the CI should confirm no?

src/test_utils/hive/mod.rs Outdated Show resolved Hide resolved
@Eikix
Copy link
Member

Eikix commented Nov 19, 2024

Why do we need to bump katana? For hive tests?

@tcoratger
Copy link
Collaborator Author

Why do we need to bump katana? For hive tests?

yes to keep everything up to date for deps, tests and hive

@Eikix
Copy link
Member

Eikix commented Nov 19, 2024

Why do we need to bump katana? For hive tests?

yes to keep everything up to date for deps, tests and hive

And as I understand, the tests are failing due to a bug, but we haven't had bandwidth to investigate why?

@tcoratger
Copy link
Collaborator Author

Why do we need to bump katana? For hive tests?

yes to keep everything up to date for deps, tests and hive

And as I understand, the tests are failing due to a bug, but we haven't had bandwidth to investigate why?

@Eikix yes we have a discussion with the Dojo team also to try to have their opinion on the topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 left review comments

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

@Eikix Eikix Awaiting requested review from Eikix Eikix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @Eikix @greged93