feat: check submodule kakarot dirty #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
approved these changes
Sep 11, 2023
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: .1 ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Gasprice was returning a nonconstant value that was dependent on execution. Resolves #<Issue number> ## What is the new behavior? Gasprice returns the amount of ether that the sender is willing to pay per unit of gas to execute the transaction. ## Other information I believe gasPrice is relayed from the rpc to the execution system, but currently only `gas_limit` is parameterized at the entry point of `execute_at_address`, so pragmaticly this opcode is always returning zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appends "-dirty" to the commit hash of Kakarot if the workdir contains local changes.
Time spent on this PR: 0.1 day
Resolves: #NA
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Adds "-dirty" for a dirty submodule.
Does this introduce a breaking change?