build(deps): bump lib/kakarot from 9f39628 to 8dda237
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [lib/kakarot](https://github.com/kkrt-labs/kakarot) from `9f39628` to `8dda237`. - [Release notes](https://github.com/kkrt-labs/kakarot/releases) - [Commits](kkrt-labs/kakarot@9f39628...8dda237) --- updated-dependencies: - dependency-name: lib/kakarot dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
requested review from
ClementWalter and
Eikix
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
===========================================
+ Coverage 23.17% 72.80% +49.63%
===========================================
Files 9 45 +36
Lines 1247 4060 +2813
===========================================
+ Hits 289 2956 +2667
- Misses 958 1104 +146
☔ View full report in Codecov by Sentry. |
Eikix
approved these changes
Sep 12, 2023
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
…bs#554) Time spent on this PR: 2.5 ## Pull request type Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? The EOAccount owns the logic of transferring native tokens and dispatching between contract deployment and contract invocation. On the other hand, the kakarot contract exposes two methods (execute_at_address & deploy_contract_account) that require the caller to know what they want to do and how they need to send the data. This is an extra complexity compared to what the EVM does: the kakarot contract should be able to handle a plain (encoded or decoded) EVM tx without requiring the caller to do any logic themselves. As a matter of fact, the EOAccount responsibility is (almost) narrowed to a standard AA responsibility: accepte a sign tx, verify signature and propagate the call. Almost because it still needs to **decode** the tx, and actually Yoav (from Braavos) thinks that we should go further and remove this **decoding** part from the EOA: only validate a signature and send the payload (encoded) to the kakarot contract. This would allow us to use Braavos contract out of the box (with a proper signer type) Resolves kkrt-labs#551 kkrt-labs#411 ## What is the new behavior? The Kakarot contract has two new entrypoints that behave as in the [ethereum RPC doc](https://ethereum.org/en/developers/docs/apis/json-rpc) - `eth_call`: Executes a new message call immediately without creating a transaction (`@view` function) - `eth_send_transaction`: Creates new message call transaction or a contract creation, if the data field contains code. (`@external` function) Along the way, the test refactoring (kkrt-labs#441) was eventually done, and the `ExecutionContext` `init` & `init_at_address` have been merged into one single general purpose `init` method. ## Other information Following a community call discussion, we could put more of these entrypoints in the main Kakarot contract: - eth_getBalance - eth_getStorageAt - eth_getTransactionCount - eth_getCode - etc. to put more logic in the core contract and less in the RPC thay may eventually require a complete refacto depending on where we actually make this kakarot live. I have added a check `compute_starknet_address(IAccount.get_evm_address(contract_address)) != contract_address` to avoid unexpected behaviors resulting from a starknet contract implementing `get_evm_address` without being **the** `ContractAccount`. I'd like to remove this sooner or later but still need to think about all the edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps lib/kakarot from
9f39628to8dda237.Commits
8dda237Add an example forge script for easy test to anvil (#741)baa93e2Migrate solidity tests to end-to-end (#729)594a75fdev: set contract account nonce to 1 after CREATE/CREATE2 (#740)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)