-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: refactor KakarotTestEnvironmentContext.seqeuncer() method to return the Arc<KatanaSeqeuncer> #576
Conversation
ffd9edb
to
9736b2c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
===========================================
+ Coverage 23.17% 72.87% +49.69%
===========================================
Files 9 45 +36
Lines 1247 4169 +2922
===========================================
+ Hits 289 3038 +2749
- Misses 958 1131 +173
☔ View full report in Codecov by Sentry. |
…urn the &Arc<KatanaSeqeuncer>
let sequencer = test_context.sequencer(); | ||
let dump_state = sequencer | ||
.sequencer | ||
.backend | ||
.state | ||
.blocking_write() | ||
.dump_state() | ||
.expect("Failed to call dump_state on Katana state"); | ||
let dump_state = | ||
sequencer.backend.state.blocking_write().dump_state().expect("Failed to call dump_state on Katana state"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can do
let dump_state=test_context.sequencer().backend.state.blocking_write().dump_state().expect("Failed to call dump_state on Katana state");
self.sequencer.sequencer.clone() | ||
} | ||
|
||
pub fn url(&self) -> Url { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn url(&self) -> Url { | |
pub fn sequencer_url(&self) -> Url { |
pub fn sequencer(&self) -> &TestSequencer { | ||
&self.sequencer | ||
pub fn sequencer(&self) -> Arc<KatanaSequencer> { | ||
self.sequencer.sequencer.clone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this pr to remove blocking, not sure if that might affect this
Closing this for now as we're deeply refactoring the codebase |
Resolves: #531
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
The
KakarotTestEnvironmentContext.seqeuncer()
method returnsArc<KatanaSeqeuncer>
which helps solve the current code smell ofKakarotTestEnvironmentContext.seqeuncer().seqeuncer
, we can now just useKakarotTestEnvironmentContext.seqeuncer()
.A getter for seqeuncer
url
has also been added to theKakarotTestEnironmentContext
+ also fixes some doc issues.Does this introduce a breaking change?