fix: rip-7212 implementation incorrect return value (#790)

* fix: rip-7212 implementation incorrect return value * fix type --------- Co-authored-by: enitrat <[email protected]>
kkrt-labs · May 6, 2024 · d7ea4af · d7ea4af
1 parent af1a8db
commit d7ea4af
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/crates/evm/src/precompiles/p256verify.cairo b/crates/evm/src/precompiles/p256verify.cairo
@@ -19,7 +19,7 @@ impl P256Verify of Precompile {
         let gas: u128 = P256VERIFY_PRECOMPILE_GAS_COST;
 
         if input.len() != 160 {
-            return Result::Ok((gas, array![0].span()));
+            return Result::Ok((gas, array![].span()));
         }
 
         let message_hash = input.slice(0, 32);
@@ -59,7 +59,7 @@ impl P256Verify of Precompile {
         };
 
         if !is_valid_signature(message_hash, r, s, public_key) {
-            return Result::Ok((gas, array![0].span()));
+            return Result::Ok((gas, array![].span()));
         }
 
         return Result::Ok((gas, array![1].span()));

diff --git a/crates/evm/src/tests/test_precompiles/test_p256verify.cairo b/crates/evm/src/tests/test_precompiles/test_p256verify.cairo
@@ -87,8 +87,7 @@ fn test_p256verify_precompile_input_too_short() {
 
     let (gas, result) = P256Verify::exec(calldata.span()).unwrap();
 
-    let result: u256 = result.from_be_bytes().unwrap();
-    assert_eq!(result, 0x00);
+    assert_eq!(result, array![].span());
     assert_eq!(gas, 3450);
 }
 
@@ -117,5 +116,5 @@ fn test_p256verify_precompile_input_too_short_static_call() {
     let mut result = Default::default();
     vm.memory.load_n(0x1, ref result, 0x80);
 
-    assert_eq!(result, array![0x00]);
+    assert_eq!(result, array![0]);
 }