Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OZ contracts #1558

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

use OZ contracts #1558

wants to merge 11 commits into from

Conversation

manlikeHB
Copy link

@manlikeHB manlikeHB commented Oct 31, 2024

Time spent on this PR:
2days

Pull request type

Please check the type of change your PR introduces:

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Resolves #1521

What is the new behavior?

Removed custom implementation of ownable, upgradeable and refactor ERC20 contract that were copy from OZ and added OZ contract dependencies.


This change is Reviewable

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, this is great work 👏

A few things to revise before merging

cairo/kakarot-ssj/crates/contracts/Scarb.toml Outdated Show resolved Hide resolved
cairo/kakarot-ssj/crates/contracts/Scarb.toml Outdated Show resolved Hide resolved
cairo/kakarot-ssj/crates/evm/Scarb.toml Outdated Show resolved Hide resolved
cairo/kakarot-ssj/crates/contracts/src/token/erc20.cairo Outdated Show resolved Hide resolved
cairo/kakarot-ssj/crates/contracts/src/token/erc20.cairo Outdated Show resolved Hide resolved
- bump OZ's version to 0.18.0
@manlikeHB manlikeHB requested a review from enitrat October 31, 2024 14:46
enitrat
enitrat previously approved these changes Oct 31, 2024
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will check why CI fails later but I think we can ignore (unrelated)

@enitrat enitrat dismissed their stale review October 31, 2024 15:52

checking ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev(SSJ): use OZ contracts
2 participants