-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update electron to v11 #317
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tusk can run normally with npm start
and solved the issues.
I tried locally and it works with However, I tried running the release command and it fails
Is there a way to proceed here? |
It cannot run release on the main branch as well. So I don't think it is the problem from this PR. There is also a workaround mentioned in this issue #308 (comment). Maybe you can try with that. I used only |
This PR has solved the command in build step #332. There's also a build and release provided in the forked repository here: https://github.com/Trip09/tusk/releases/tag/v1.0.0 |
Thanks @fonylew 👍 |
Fixes #314 #315 #308 and their related issues.
Done by executing
yarn add electron@latest
.Screenshot:

For tests to pass, I created the PR #316
Thanks for your attention and work on Tusk!