Multiple masonry containers in single page and imagesLoaded fix #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in issue klederson#27, multiple masonry elements in a single page do not work. Changes have been made in the js file to facilitate the same. I’ve tested this in one of my projects and is working fine. Hence I thought, I may contribute to this library to make the same available in the coming release.
shashank1992
changed the title
|
Great! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in issue #27, multiple masonry elements in a single page
do not work. Changes have been made in the js file to facilitate the
same. I’ve tested this in one of my projects and is working fine.
This also fixes the imagesLoaded not executed problem as pointed out in issue #19.