Conversation
✅ Deploy Preview for kleros-court ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jaybuidl
force-pushed
the
refactor/env-vars
branch
from
39cc727 to
7748a1b
Compare
jaybuidl
assigned
greenlucid,
alcercu and
kemuru and unassigned
greenlucid,
alcercu and
kemuru
jaybuidl
force-pushed
the
refactor/env-vars
branch
from
919e628 to
5a04dc1
Compare
kemuru
requested changes
Jan 22, 2024
Contributor
kemuru
left a comment
kemuru
left a comment
There was a problem hiding this comment.
simulating this address, this is what im seeing on the current deploy (court.kleros.io):
and this is what im seeing on your preview:
also seeing these errors in console in your preview (which im not seeing in (court.kleros.io):
alcercu
suggested changes
Jan 23, 2024
Comment on lines
+7
to
+8
| "uniswapV2Router02Address": "0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D", | ||
| "uniswapV2FactoryAddress": "0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f", |
Contributor
There was a problem hiding this comment.
These addresses are from the old .env but are not present on netlify.toml 🤔
.env
REACT_APP_UNISWAP_V2_ROUTER_02_ADDRESS=0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D
REACT_APP_UNISWAP_V2_FACTORY_ADDRESS=0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f
netlify.toml
REACT_APP_UNISWAP_EXCHANGE_ADDRESS='0xF506828B166de88cA2EDb2A98D960aBba0D2402A'
|
Member
Author
|
Too old, diverged too much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the deployment related env vars have been moved to a json file in
src/assets/deployments/[network name].json.The other env vars are handled by the Netlify console, most of them are RPC-related.
PR-Codex overview
This PR updates contract addresses and deployment information, improves fallback URL handling, and refactors network configuration for better readability.
Detailed summary