Dependency bumps: node 18 to 22 #403
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the Node.js version specified in the volta sections across several package.json files. The version is changed from "18.20.7" to "22.14.0" in multiple components including contracts, CLI tools, subgraphs, and the web interface. The engines requirement remains unchanged, ensuring that Node.js versions from 18.0.0 onward continue to be supported. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Deploy Preview for veascan failed. Why did it fail? →
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
validator-cli/package.json (1)
23-23: Upgrade to ethers v6 in CLI Dependency
The dependency on"@typechain/ethers-v6": "^0.5.1"indicates the switch to ethers v6 as part of the CLI packages update. Please verify that this change does not introduce breaking changes in any CLI functionalities that interact with the Ethereum blockchain. Thorough regression tests and integration checks are recommended.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
contracts/package.json(1 hunks)package.json(1 hunks)relayer-cli/package.json(1 hunks)relayer-subgraph-inbox/package.json(1 hunks)validator-cli/package.json(1 hunks)veascan-subgraph-inbox/package.json(1 hunks)veascan-subgraph-outbox/package.json(1 hunks)veascan-web/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Redirect rules - veascan
- GitHub Check: Header rules - veascan
- GitHub Check: Pages changed - veascan
- GitHub Check: dependency-review
- GitHub Check: Analyze (javascript)
🔇 Additional comments (8)
relayer-cli/package.json (1)
7-9: Node Version Upgrade in Volta Configuration
The Node version in the volta section has been updated from the previous value to"22.14.0". This upgrade aligns with the overall repository update to Node 22. Please ensure that all CLI tooling and scripts in this package are compatible with Node 22.relayer-subgraph-inbox/package.json (1)
7-9: Update Node Version in Volta Section
The volta configuration now specifies"node": "22.14.0", which standardizes the development environment across packages. Confirm that any graph CLI commands or subgraph tooling continue to function correctly with Node 22.veascan-subgraph-inbox/package.json (1)
7-10: Standardizing the Node Environment
The Node version change to"22.14.0"in the volta section ensures consistency with other subgraph packages. It is advisable to run a smoke test for subgraph code generation and deployment to ensure full compatibility with Node 22.veascan-subgraph-outbox/package.json (1)
7-10: Volta Node Version Update
The updated volta configuration now specifies"node": "22.14.0", aligning this package with the newer Node.js environment. Make sure that all scripts, especially those related to builds and deployments, are validated against Node 22.validator-cli/package.json (1)
7-10: Node Version Consistency for Validator CLI
The volta section here has been updated to"node": "22.14.0", which maintains consistency across CLI packages. Ensure that any Node-specific behavior in this CLI is re-tested under Node 22.package.json (1)
28-30: Update Node.js Version in Volta Config
The volta configuration has been updated from Node.js 18.20.7 to 22.14.0. This change is consistent with the project-wide upgrade outlined in the PR objectives. Please verify that all CLI tools and scripts relying on this configuration are compatible with Node 22.veascan-web/package.json (1)
16-18: Consistent Node.js Version Bump in Volta
The Node.js version in the volta field has been updated to "22.14.0", matching the project's new standard. Ensure that any Node.js–specific code within this package is tested against Node 22 to catch potential compatibility issues.contracts/package.json (1)
24-26: Update Node.js Version and Ethers Dependency
The volta section now reflects Node.js "22.14.0", which aligns with the overall update across the project. Additionally, the ethers dependency in devDependencies is now at "^6.13.5", effectively bumping it to version 6 as intended. Verify that all deployments and contract interactions remain stable under these new versions.
jaybuidl
changed the title
jaybuidl
force-pushed
the
chore/node-ethers-upgrades
branch
from
57a0e2a to
31643e3
Compare
|
PR-Codex overview
This PR updates the
nodeversion in multiplepackage.jsonfiles from18.20.7to22.14.0, ensuring compatibility with newer features and improvements.Detailed summary
nodeversion from18.20.7to22.14.0in the following files:relayer-cli/package.jsonvalidator-cli/package.jsoncontracts/package.jsonrelayer-subgraph-inbox/package.jsonveascan-subgraph-inbox/package.jsonveascan-subgraph-outbox/package.jsonveascan-web/package.jsonpackage.jsonSummary by CodeRabbit
Summary by CodeRabbit