fix: spirit name random despite using renamed dictionary

Closes #1198
klikli-dev · Aug 29, 2024 · acfa07e · acfa07e
1 parent dfc1b0c
commit acfa07e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/com/klikli_dev/occultism/common/item/spirit/BookOfBindingBoundItem.java b/src/main/java/com/klikli_dev/occultism/common/item/spirit/BookOfBindingBoundItem.java
@@ -40,7 +40,6 @@ public BookOfBindingBoundItem(Item.Properties properties) {
         super(properties);
     }
 
-
     @Override
     public void appendHoverText(ItemStack stack, @Nullable Level worldIn, List<Component> tooltip,
                                 TooltipFlag flagIn) {
@@ -49,10 +48,9 @@ public void appendHoverText(ItemStack stack, @Nullable Level worldIn, List<Compo
                 TextUtil.formatDemonName(ItemNBTUtil.getBoundSpiritName(stack))));
     }
 
-
     @Override
     public void onCraftedBy(ItemStack pStack, Level pLevel, Player pPlayer) {
-        ItemNBTUtil.generateBoundSpiritName(pStack);
+        ItemNBTUtil.generateBoundSpiritNameIfNone(pStack);
         super.onCraftedBy(pStack, pLevel, pPlayer);
     }
 }
diff --git a/src/main/java/com/klikli_dev/occultism/util/ItemNBTUtil.java b/src/main/java/com/klikli_dev/occultism/util/ItemNBTUtil.java
@@ -70,7 +70,12 @@ public static void updateItemNBTFromEntity(ItemStack stack, SpiritEntity entity)
             if (job.getManagedMachine() != null)
                 ItemNBTUtil.setManagedMachine(stack, job.getManagedMachine());
         });
+    }
 
+    public static void generateBoundSpiritNameIfNone(ItemStack stack) {
+        if(!stack.hasTag() && !stack.getTag().contains(SPIRIT_NAME_TAG)) {
+            generateBoundSpiritName(stack);
+        }
     }
 
     public static void generateBoundSpiritName(ItemStack stack) {