Implement stream encoding #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingtnet
force-pushed
the
stream-encoding
branch
from
53e7144
to
a87a05e
Compare
Closed
klingtnet
force-pushed
the
stream-encoding
branch
3 times, most recently
from
54a0db5
to
8d48073
Compare
This implements OSC packet stream encoding in encode_tcp. Closes #47.
klingtnet
force-pushed
the
stream-encoding
branch
from
8d48073
to
0865e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
encode_tcpand fixes a bug when decoding a message that contains multiple packets. The implementation is still pretty basic, ideallyencode_tcpshould accept anOutputtrait object to encode into.TODOS
decode_tcpfunction was correct, I think. What I need to verify is, if it's okay to add OSC Packets to an OSC Bundle if the bundle comes first, because that's how the original implementation behaves. Commit 53e7144 reverts the "fix".