Fix: Decoding a udp buffer with an argument of type blob fails with nom error EOF. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed when using decoder::decode() on a udp packet with a blob argument it fails with a nom EOF error when the blob size is a multiple of 4. I tracked this to the pad_to_32_bit_boundary() of read_blob().
This parser seems to assume that if the blob is a multiple of 4, there will be 4 more zero bytes to take(), but from my experience this isn't the case. Giving it another modulo so that multiples of 4 take 0 additional bytes fixed my issue.