Fix(websocket): Do not crash app when a reserved close code is passed (Android) #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Android
The following line throws an error when the
code
argument passed to theclose
method is a reserved number. The plugin doesn't handle this error currently. And, the app crashes with an error similar toCode 1005 is reserved and may not be used.
https://github.com/square/okhttp/blob/master/okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/ws/WebSocketProtocol.kt#L146
iOS
The app doesn't crash.
onClose
listener gets called with code1001
.What is the new behavior?
Android
This update makes the plugin handle this error that otherwise crashes the app.
Added Try-Catch Block:
Reserved Close Code Check
Fallback to Standard Close Code:
iOS
Nothing changed.