Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search for KLP schools #563

Open
batpad opened this issue Aug 4, 2015 · 20 comments
Open

Advanced search for KLP schools #563

batpad opened this issue Aug 4, 2015 · 20 comments

Comments

@batpad
Copy link
Collaborator

batpad commented Aug 4, 2015

We need a more advanced search to filter KLP schools (and boundaries?) .. just listing out some features that this would need to support here. Everyone, please add to the list. We can discuss features required here and then perhaps break out separate tickets for design and API implementation.

  • Search for school by programme (schools that had a programme run in that school)
  • Search by having SDMC / BVS meeting PDF
  • By medium of instruction?
  • By num of boys / girls?

Please add use-cases for the advanced search .. /cc @gkjohn @meghaklp @iambibhas

@gkjohn
Copy link
Collaborator

gkjohn commented Aug 4, 2015

  • By partner
  • By academic year
  • By school type
  • By management
  • By geography
  • By category
  • By gender
  • By MP/MLA/PIN/GP/ZP

@batpad
Copy link
Collaborator Author

batpad commented Sep 15, 2015

Okei, we should have all those now except "by academic year" .. @iambibhas any idea what might be a good way to filter for schools that have information for a particular academic year?

Will write up some docs for the existing filters, but they're pretty straightforward ..

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

search2

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

Megha Vishwanath [3:23 PM]
On this dialogue - the grey sections show up based on the checkboxes checked in the first line of choices. Also, maybe better if transposed for mobile viewing - i.e, headings in the grey section which are now row names, would be better off as column names and the choices agains them can just grow vertically (edited)

Megha Vishwanath [3:24 PM]
It's fairly complex... if you had something simpler in mind, let me know. We can talk whenever you have time. (edited)

Sanjay Bhangar [3:46 PM]
oo @megha looks really nice ..

Sanjay Bhangar [3:46 PM]
not sure if it can really be simplified ..

Gautam John [5:40 PM]
This is a little terrifying.

Gautam John [5:41 PM]
And wouldn't somethings be better as a multi/select? (edited)

Megha Vishwanath [7:51 PM]
Okay, if it's less terrifying, the checkboxes in the grey area can be made into multi selects (not just selects though). But I've rarely seen a multi select in a Mobile form. Have you? @Gautam

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

search2 1

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

Tried the "transpose" of row and column that I talked about and multi-select boxes

Megha Vishwanath [8:36 PM]
Personally, I still like checkboxes.

Gautam John [8:57 PM]
You are correct

@gkjohn
Copy link
Collaborator

gkjohn commented Oct 6, 2015

@meghaklp Can we start simple and work towards complexity? Because this is overwhelming. So, for example, first step to have filter by partner (multi-select) and by partner/program (multi-select). And then by academic year (multi-select)

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

Sure- this is actually a framework for the search, we can start with 2 parameters and then keep adding - each time a check box is selected - a grey area below expands and choices come up.

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

@gkjohn - I still don't like the idea of multi selects. I don't think it makes for good interaction on mobile. But if you insist, we can do multi selects.

@gkjohn
Copy link
Collaborator

gkjohn commented Oct 6, 2015

@meghaklp Sure. Doesn't have to be multi-select as we usually do. Just needs to be a way to select multiple options - any other way is fine.

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

@gkjohn
Copy link
Collaborator

gkjohn commented Oct 6, 2015

@meghaklp Sure. Give it a shot?

@meghaklp
Copy link
Collaborator

meghaklp commented Oct 6, 2015

@batpad @aksanoble - Did either of you start on this? Should I be writing HTML and then leaving the js tie in to api to @aksanoble?

@gkjohn
Copy link
Collaborator

gkjohn commented Oct 6, 2015

@meghaklp @batpad Said most of the APIs done. @iambibhas any idea where?

@batpad
Copy link
Collaborator Author

batpad commented Oct 6, 2015

@gkjohn @iambibhas have added those filters to the SchoolList end-point .. I think I pushed to develop, but may also be in a branch, checking ..

@meghaklp
Copy link
Collaborator

search_1
search_2
search_3

@meghaklp
Copy link
Collaborator

@gkjohn - So, this is a scrollable search modal, with a multi select. Still fixing some mobile issues.

Not sure if we should just select by program or pick a partner first. What are your thoughts?
For now i can comment all other code except the select by programme.

@meghaklp
Copy link
Collaborator

On the branch search_modal - @aksanoble @iambibhas - Still fixing some issues though.

@gkjohn
Copy link
Collaborator

gkjohn commented Nov 2, 2015

@meghaklp This looks good. Pick partner first.

@meghaklp
Copy link
Collaborator

meghaklp commented Nov 2, 2015

Think I'm done here @aksanoble @iambibhas . Let's discuss this, when you pick this feature up to work on. The ui changes are on "search-modal".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants