Skip to content

Conversation

Flying-Tom
Copy link
Contributor

Set the Istio version to 1.24.0 to ensure compatibility with the Waypoint feature and provide a note regarding version limitations.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit ac671f2
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/68d5245d723f6e0008e35753
😎 Deploy Preview https://deploy-preview-239--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Summary of Changes

Hello @Flying-Tom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the development setup documentation by specifying Istio version 1.24.0 for installation, which is crucial for compatibility with the Waypoint feature. It also introduces a clear warning about the maximum supported Istio version (1.25) when utilizing Waypoint, thereby preventing potential issues for developers.

Highlights

  • Istio Version Update: The Istio installation script has been updated to explicitly set the version to 1.24.0, ensuring consistent deployment.
  • Waypoint Feature Compatibility Note: A new note has been added to the documentation, informing users that for the Waypoint feature, the Istio version should not exceed 1.25.
  • Documentation Clarity: The changes improve the clarity and accuracy of the development setup documentation for users working with Kind and Istio.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Istio installation instructions in the development guide to use a specific version (1.24.0) which is compatible with the Waypoint feature. This is a good improvement as it fixes an issue where the documentation was inconsistent. The changes are also applied to the Chinese translation. I've added a suggestion to improve the clarity of the note about version compatibility.

@hzxuzhonghu
Copy link
Member

@Flying-Tom We should also figure out how istio makes it uncompatible with kmesh

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 11:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Istio version specifications across documentation files to ensure compatibility with the Waypoint feature. It sets a specific Istio version (1.24.0/1.25.0) and adds version limitation notes for Waypoint functionality.

  • Specifies exact Istio versions in installation commands (1.24.0 for istioctl, 1.25.0 for Helm)
  • Updates version compatibility notes to indicate tested ranges (1.22-1.25)
  • Adds warnings about Waypoint feature requiring Istio versions no higher than 1.25

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docs/setup/quick-start.md Updates Helm installation to specify version 1.25.0 and adds Waypoint version limitation note
docs/setup/develop-with-kind.md Specifies Istio 1.24.0 for istioctl installation and adds Waypoint version warning
i18n/zh/docusaurus-plugin-content-docs/current/setup/quick-start.md Chinese translation of quick-start changes
i18n/zh/docusaurus-plugin-content-docs/current/setup/develop-with-kind.md Chinese translation of develop-with-kind changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants