Sharp/flats toggle #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks a lot for your project!!
I just started using it, but I noticed you haven't implemented a toggle between sharp notes (e.g., C#) and flat versions (e.g., Db).
I haven't found any requests or pull requests already, so here's my attempt -- I'm not a JS developer, so I tried my best.
For the music theorists out there: I chose to implement this by committing the cardinal sin of ignoring edge cases such as B#, Cb, Fb, E#. I prefer favoring legibility over technical correctness. The toggles switches between the following notes: