-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add IFSC service #85
base: master
Are you sure you want to change the base?
Conversation
# You will need to manually download the IFSC data | ||
# Download from https://github.com/razorpay/ifsc/releases/download/latest/by-bank.tar.gz | ||
# Untar the folder and save its contents within data/ifsc directory | ||
ifsc_path = "data/ifsc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below might be a useful addition to quick start this, a single commad to download and untar. Same canbe used in a cronjob to keep it upto date. Also might be useful to retain the by-bank/ folder incase another method / file from razorpay also needs to be included. The below unatars into ifsc/by-bank/
cd [your_dns_toys_data_directory] && mkdir -p ifsc && cd ifsc && mkdir -p by-bank && rm -r by-bank && curl -L -s $(curl -s https://api.github.com/repos/razorpay/ifsc/releases/latest | grep "browser_download_url" | grep "by-bank.tar.gz" | sed -E 's/.*"([^"]+)".*/\1/') -o by-bank.tar.gz && tar -xzf by-bank.tar.gz && rm by-bank.tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might also want to add data/ifsc to gitignore
Branch string `json:"BRANCH"` | ||
City string `json:"CITY"` | ||
State string `json:"STATE"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to send everything that is available instead of restricting to these 5?
Add IFSC service - Closes #81
IFSC data is read from disk and loaded into memory to respond to requests. The download link mentioned in
config.sample.toml
fetches the latest dump of IFSC data.make build
output