Nits

Signed-off-by: Ansu Varghese <[email protected]>

pkg/common/scheduler/statefulset/scheduler.go

@@ -140,13 +140,14 @@ func (s *StatefulSetScheduler) Schedule(vpod scheduler.VPod) ([]duckv1alpha1.Pla
 	placements := vpod.GetPlacements()
 	spreadVal := int32(0)
 
-	// The scheduler
-	// Policy: MaxFillup
+	// The scheduler when policy type is
+	// Policy: MaxFillup (schedulePolicy == false)
 	// - allocates as many vreplicas as possible to the same pod(s)
 	// - allocates remaining vreplicas to new pods
-	// Policy: EvenSpread
-	// - allocates vreplicas to new pods until
-	// - allocates remaining vreplicas to existing pods
+	// Policy: EvenSpread (schedulePolicy == true)
+	// - divides up vreplicas equally between the zones and 
+	// - allocates as many vreplicas as possible to existing pods while not going over the equal spread value
+	// - allocates remaining vreplicas to new pods created in new zones still satisfying equal spread
 
 	// Exact number of vreplicas => do nothing
 	tr := scheduler.GetTotalVReplicas(placements)
@@ -177,12 +178,11 @@ func (s *StatefulSetScheduler) Schedule(vpod scheduler.VPod) ([]duckv1alpha1.Pla
 	// Need more => scale up
 	logger.Infow("scaling up", zap.Int32("vreplicas", tr), zap.Int32("new vreplicas", vpod.GetVReplicas()))
 	placements, left := s.addReplicas(state, vpod.GetVReplicas()-tr, placements, spreadVal)
-	logger.Infow("scheduling not done", zap.Any("placement", placements), zap.Int32("left", left))
 	if left > 0 {
-		s.pending[vpod.GetKey()] = left
-
 		// Give time for the autoscaler to do its job
-		logger.Info("scheduling failed (not enough pod replicas)", zap.Any("placement", placements), zap.Int32("pending reps:", s.pendingVReplicas()))
+		logger.Info("scheduling failed (not enough pod replicas)", zap.Any("placement", placements), zap.Int32("left:", left))
+
+		s.pending[vpod.GetKey()] = left
 
 		// Trigger the autoscaler
 		if s.autoscaler != nil {