Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Stream Source Unit + E2E Tests #5

Merged
merged 22 commits into from
Oct 19, 2020

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Oct 6, 2020

Included in this PR:

  • Unit tests for stream source api, lifecycle test, adapter, receive adapter etc
  • Vendor dir updates (after updating K8 deps to v18.8)
  • Code updates (after updating K8 deps to v18.8)
  • Setup for github actions
  • Adding test dir

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2020
@aavarghese aavarghese marked this pull request as draft October 6, 2020 20:27
@knative-prow-robot knative-prow-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 6, 2020
@aavarghese
Copy link
Contributor Author

aavarghese commented Oct 6, 2020

https://github.com/aavarghese/eventing-redis/runs/1221235701?check_suite_focus=true

Github showing same error as my local setup, even after updating all dependencies.

vendor/knative.dev/pkg/metrics/stackdriver_exporter.go:357:65: too many arguments in call to kubeclient.CoreV1().Secrets(secretNamespace).Get
	have (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
	want (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
# knative.dev/pkg/test/ingress
vendor/knative.dev/pkg/test/ingress/ingress.go:51:71: too many arguments in call to kubeClientset.CoreV1().Services(ingressNamespace).Get
	have (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
	want (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
# knative.dev/pkg/test/monitoring
vendor/knative.dev/pkg/test/monitoring/monitoring.go:49:58: too many arguments in call to kubeClientset.CoreV1().Pods(namespace).List
	have (context.Context, "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
	want ("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
FAIL	knative.dev/eventing-redis/test/e2e [build failed]
# knative.dev/pkg/apis/duck
vendor/knative.dev/pkg/apis/duck/typed.go:52:44: too many arguments in call to dif.Client.Resource(gvr).List
	have (context.Context, "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
	want ("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
vendor/knative.dev/pkg/apis/duck/typed.go:58:62: cannot use dif.Client.Resource(gvr).List (type func("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions) (*unstructured.UnstructuredList, error)) as type unstructuredLister in argument to asStructuredLister
vendor/knative.dev/pkg/apis/duck/typed.go:59:63: cannot use dif.Client.Resource(gvr).Watch (type func("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions) (watch.Interface, error)) as type structuredWatcher in argument to AsStructuredWatcher

Am I missing some other step other than hack/update*.sh? cc: @lionelvillard

@aavarghese aavarghese changed the title [WIP] Redis Stream Source E2E tests [WIP] Redis Stream Source Unit + E2E Tests Oct 13, 2020
@aavarghese aavarghese changed the title [WIP] Redis Stream Source Unit + E2E Tests Redis Stream Source Unit + E2E Tests Oct 13, 2020
@aavarghese aavarghese marked this pull request as ready for review October 13, 2020 22:40
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2020
@aavarghese
Copy link
Contributor Author

cc @lionelvillard this set ready for review. I don't have an e2e test functional yet but other than that, test setup version 1 is in this PR. Can you take a look and let me know what you think so far?

@knative-prow-robot knative-prow-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 14, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2020
@lionelvillard
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2020
@knative-prow-robot knative-prow-robot merged commit 5d945aa into knative-extensions:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants