Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from knative:master #40

Open
wants to merge 3,001 commits into
base: master
Choose a base branch
from
Open

[pull] master from knative:master #40

wants to merge 3,001 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 19, 2019 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]. Want to support this open source service? Please star it : )

@pull pull bot added the ⤵️ pull label Nov 19, 2019
@knative-prow-robot
Copy link
Owner

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Owner

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a knative-prow-robot member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Owner

The following users are mentioned in OWNERS file(s) but are not members of the knative-prow-robot org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • mattmoor
    • OWNERS_ALIASES
  • mdemirhan
    • OWNERS_ALIASES
  • shashwathi
    • OWNERS_ALIASES
  • andrew-su
    • OWNERS_ALIASES
  • dprotaso
    • OWNERS_ALIASES
    • pkg/apis/OWNERS
  • grantr
    • OWNERS_ALIASES
  • julz
    • OWNERS_ALIASES
  • markusthoemmes
    • OWNERS_ALIASES
  • vagababov
    • OWNERS_ALIASES
  • evankanderson
    • OWNERS_ALIASES
  • nak3
    • OWNERS_ALIASES
  • tcnghia
    • OWNERS_ALIASES
  • yanweiguo
    • OWNERS_ALIASES

vagababov and others added 17 commits January 14, 2021 15:07
@vagababov
Remove the old constant since the new one has been since August 2020 (#…
e402e8e 
…10559)

So 0.18, 0.19 and 0.20 have both labes, enough time now to deprecate the
old one.

Change-Id: I510ee88b97784b2d836b9caf5262d268568e7495
@markusthoemmes
Shutdown processor to avoid log races (#10544)
84421cd 
* Shutdown processor to avoid log races

* Actually just fix the test
@knative-automation
upgrade to latest dependencies (#10562)
9979954 
bumping knative.dev/networking 4c4c237...07a8160:
  > 07a8160 upgrade to latest dependencies (# 331)
bumping knative.dev/hack d946d25...4422dca:
  > 4422dca Set GOBIN in codegen-library.sh (# 44)
bumping knative.dev/pkg acbf2af...f0ea5e6:
  > f0ea5e6 Use special error type to designate skips. (# 1988)

Signed-off-by: Knative Automation <[email protected]>
@markusthoemmes
Widen timeouts for queue probe tests to harden them (#10555)
9b69859
@markusthoemmes
Cut down the probe test runtime from 18s to 3s (#10546)
fbd3968
@markusthoemmes
Cut down queue health tests from 2s to basically nothing (#10556)
66389d3
@knative-automation
Update net-istio nightly (#10550)
cb128a4 
bumping knative.dev/net-istio 9f0302e...b4b1c95:
  > b4b1c95 upgrade to latest dependencies (# 481)
  > ed8a994 Add test for virtualservice status config (# 472)
  > 8ade02d upgrade to latest dependencies (# 478)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-kourier nightly (#10552)
80321c4 
bumping knative.dev/net-kourier 707240d...c29bd73:
  > c29bd73 upgrade to latest dependencies (# 418)
  > 7ff0388 upgrade to latest dependencies (# 417)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
upgrade to latest dependencies (#10568)
3135ad4 
bumping knative.dev/networking 07a8160...356d71b:
  > 356d71b upgrade to latest dependencies (# 332)
bumping knative.dev/caching 1ee4750...3657044:
  > 3657044 upgrade to latest dependencies (# 414)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-certmanager nightly (#10564)
a8c2dae 
bumping knative.dev/net-certmanager 05a48f5...2027b5a:
  > 2027b5a upgrade to latest dependencies (# 166)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-contour nightly (#10565)
b5cd2eb 
bumping knative.dev/net-contour 8bb7f0f...08b6448:
  > 08b6448 Add a CODEOWNERS to experiment with different review gating. (# 399)
  > d57abb5 upgrade to latest dependencies (# 398)

Signed-off-by: Knative Automation <[email protected]>
@senthilnathan @julz
Fixed comment about autoscaler logging config override (#10569)
8509e6e 
* Fixed comment about autoscaler logging config override

* Ran hack/update-codegen.sh

* Fixed a grammar error.

Co-authored-by: Julian Friedman <[email protected]>

* Re-ran ./hack/update-codegen.sh after the recent change

Co-authored-by: Julian Friedman <[email protected]>
@julz
Be consistent in reading revision headers (#10563)
078edf2 
Context_handler uses the _first_ RevisonName/Namespace header, whereas
request_log uses the _last_.

In practice the Revision header is added by AppendHeaders which
(confusingly) actually overwrites rather than appending, so there's only
ever one value of the header so this doesn't make any difference -- but
doing it the same way in both places is both (a) nicer / less confusing
and (b) lets us drop our custom LastHeaderValue function in favour of
using the standard golang net/http header.Get in both places.
@dprotaso
Drop logger annotations (#10570)
b7a7c18 
* bump knative.dev/pkg

* run update-codegen

* no need to annotate logger
@vagababov
Add the new annotation for the rollout duration and its validation (#…
59e35cd 
…10561)

Add the new validation. Given that users might specify longer durations,
e.g. in minutes or even hours, make it a time.Duration format.

Add validation and related tests.

Also sort the permitted annotation list.

Next: invoke validation in service and route.
Change-Id: Ic96786bad34cf17e29de142194d942f43e75e19c
Add a serviceUID label to ksvc (and implicitly to config) (#10539)
3177cc7 
This will allow people to find all pods for a service w/o running into the
problem of finding pods associated with an old ksvc that just happens to
share the same name. With this the user can search for pods by the ksvc UID
via the new label.

Rather than having the code go and lookup the ksvc from the revision, I
decided to just add this label to the config as well. If people would prefer
to not have this extra label on the config (and do it via a ksvc lookup)
I can look into that change.

Signed-off-by: Doug Davis <[email protected]>
@knative-automation
upgrade to latest dependencies (#10574)
5fbe2f1 
bumping knative.dev/networking 356d71b...e223a89:
  > e223a89 upgrade to latest dependencies (# 333)

Signed-off-by: Knative Automation <[email protected]>
julz and others added 27 commits March 3, 2021 09:06
@julz
Use type-safe atomics (#10881)
79faf2b
@knative-automation
Update net-istio nightly (#10875)
eb873de 
bumping knative.dev/net-istio 713aacd...fe7d984:
  > fe7d984 upgrade to latest dependencies (# 529)
  > 212691e Consolidate lines in CODEOWNERS, drop hack/test (# 531)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-contour nightly (#10876)
4301fa1 
bumping knative.dev/net-contour 06975c3...0b2656a:
  > 0b2656a upgrade to latest dependencies (# 439)
  > 6a27571 Consolidate lines in CODEOWNERS, drop hack/test (# 438)

Signed-off-by: Knative Automation <[email protected]>
@julz
Parallelise tests in activator/net (#10880)
0b07d94 
* Parallelise tests in activator/net

This takes the test time from around 6 seconds on my laptop to under a
second.

* Missed one
@dprotaso
Don't override the queue-proxy image on pre-upgrade tests (#10872)
6d84c5b 
* Don't override the queue-proxy image on pre-upgrade tests

Applying the test resources actually built a new queue-proxy image.
This would cause pre-upgrade tests to fail if the queue-proxy had any
incompatible changes

* fix namespace
@knative-automation
Update net-kourier nightly (#10877)
9419b6a 
bumping knative.dev/net-kourier 4ccf021...60f07fa:
  > 60f07fa upgrade to latest dependencies (# 459)
  > f45357a upgrade to latest dependencies (# 455)
  > 2f7fa54 Run prober when LoadBalancer in KIngres status is updated (# 444)
  > 7a1464b Try alternate CODEOWNERS layout (# 458)

Signed-off-by: Knative Automation <[email protected]>
@julz
Lint use of type-safe atomics (#10882)
c4e05e5 
* Lint use of type-safe atomics

* Just use default for list type
@julz
Add DomainMapping namespace label annotation (#10868)
267697a 
* Add DomainMapping namespace label annotation

I don't know how useful this is since the DM/route namespace and ingress
NS are always the same, but adding this to be consistent with Route
which adds a similar label.

* weird vim bug
@knative-automation
upgrade to latest dependencies (#10884)
3ee7319 
bumping knative.dev/networking 54c0eb1...c369ab0:
  > c369ab0 upgrade to latest dependencies (# 360)
bumping knative.dev/caching ac5fcb4...4863ed6:
  > 4863ed6 upgrade to latest dependencies (# 430)
bumping knative.dev/pkg 08fc626...8fbab7e:
  > 8fbab7e Redo the comment a bit further (# 2042)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-kourier nightly (#10887)
c508400 
bumping knative.dev/net-kourier 60f07fa...7956121:
  > 7956121 upgrade to latest dependencies (# 461)
  > f9c534c set alpn protocols to h2,http/1.1 on downstream tls context (# 442)
  > a562456 Simplify gateway config (# 456)
  > 5253737 upgrade to latest dependencies (# 460)

Signed-off-by: Knative Automation <[email protected]>
@julz
Update contributing link (#10894)
59c9461
@knative-automation
Update net-istio nightly (#10889)
b089ba7 
bumping knative.dev/net-istio fe7d984...6ef3289:
  > 6ef3289 upgrade to latest dependencies (# 534)

Signed-off-by: Knative Automation <[email protected]>
@julz
Bump timeout to (hopefully) avoid flake (#10892)
17e40b1 
Not totally sure that this is what happened, but it's easy to bump this
and see if the problem goes away before worrying about anything more
difficult. We're now running these tests in parallel, so it's possible
this caused us to take slightly longer to see an update.
@dprotaso
rename queueproxy flag probe-period to probe-timeout (#10855)
2955f95
@knative-automation
Update net-contour nightly (#10886)
39cd0ea 
bumping knative.dev/net-contour 0b2656a...9bf6ea2:
  > 9bf6ea2 upgrade to latest dependencies (# 440)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update net-certmanager nightly (#10888)
5b07374 
bumping knative.dev/net-certmanager ffa73df...0b60545:
  > 0b60545 upgrade to latest dependencies (# 189)
  > d8d5c29 add common name to cert (# 188)
  > b97ef13 upgrade to latest dependencies (# 187)

Signed-off-by: Knative Automation <[email protected]>
@dprotaso
e2e - wait for deployments to be available (#10883)
6087145 
* wait for deployments to be available

* don’t use my alias
@knative-automation
Format markdown (#10898)
6e46a52 
Signed-off-by: Knative Automation <[email protected]>
@markusthoemmes
Fix wrong function name in test log (#10902)
a4908c6
@markusthoemmes
Fix polling condition in KPA test (#10899)
a92d5ff
@julz
Use atomic.Value rather than unsafe.Pointer (#10901)
e718cd4 
* Use atomic.Value rather than unsafe.Pointer

* Drop exception from linter \o/
@julz
Revert Parallelise tests in activator/net (#10880) (#10904)
e50cc97 
This seems to have introduced some flakiness. Ideally we'd fix those
flakes and keep the parallelisation but I think it's going to be easier
to fix the flakes after some tidying of this package, and in the
meantime I don't want everyone to have to deal with flaky tests.
@knative-automation
upgrade to latest dependencies (#10909)
7b1c480 
bumping knative.dev/networking c369ab0...f813b59:
  > f813b59 upgrade to latest dependencies (# 361)
bumping knative.dev/hack 8368e1f...f99a255:
  > f99a255 Schema tool for reflective schema generation. (# 51)
bumping knative.dev/pkg 8fbab7e...7f753ea:
  > 7f753ea Slash off 5s from TestAdmissionValidResponseForResource (# 2046)
  > 1002883 Add kn-plugin-admin to downstream tests (# 1983)
  > 04fdbd7 Add WaitForCacheSyncQuick and use it in tests (# 2045)
bumping knative.dev/caching 4863ed6...5ce2f83:
  > 5ce2f83 upgrade to latest dependencies (# 431)

Signed-off-by: Knative Automation <[email protected]>
@wzshiming
Fix locking (#10910)
03e15be
@knative-automation
Update net-kourier nightly (#10913)
dae56e1 
bumping knative.dev/net-kourier 7956121...761c44c:
  > 761c44c upgrade to latest dependencies (# 462)

Signed-off-by: Knative Automation <[email protected]>
@markusthoemmes
Bump autoscaler resources to be equal to controller resources (#10865)
66cd8ee 
The autoscaler is a controller of a few resources after all and it's
doing a lot more work asynchronously too.
@markusthoemmes
Run kind actions on main branch as well (#10915)
1640d27
@knative-prow-robot
Copy link
Owner

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the knative-prow-robot org. You can then trigger verification by writing /verify-owners in a comment.

  • mattmoor
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • nak3
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • vagababov
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • yanweiguo
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • dprotaso
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • pkg/apis/OWNERS
  • evankanderson
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • julz
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • shashwathi
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • tcnghia
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • whaught
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • andrew-su
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • grantr
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • markusthoemmes
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@markusthoemmes markusthoemmes deleted the branch knative-prow-robot:master March 8, 2021 17:41
@markusthoemmes markusthoemmes deleted the master branch March 8, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull do-not-merge/invalid-owners-file needs-ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.