Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
- Coverage 66.39% 66.32% -0.07%
==========================================
Files 56 54 -2
Lines 2693 2646 -47
==========================================
- Hits 1788 1755 -33
+ Misses 772 763 -9
+ Partials 133 128 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
|
Companion release-1.24 fix and advance deprecation notice: #2367. This PR now clears the v1.24 SecurityGuardDeprecated condition on upgrade, replacing it with SecurityGuardIgnored when enabled (and clearing it when disabled). |
ee20751 to
ded9aeb
Compare
ded9aeb to
dd603c1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0001e24 to
404f320
Compare
7e9d9cf to
9325150
Compare
|
/hold for review |
Summary
Remove the retired alpha Security Guard integration for Operator v1.25, tracked in knative/community#1802.
Rebased onto
main. The v1.24 compatibility fix in #2367 has merged intorelease-1.24; this removal targetsmainonly and includes the warning/status handling that is not present onmain.SecurityGuardDeprecatedwarning/status handling with the message:Security Guard is no longer supported. spec.security.securityGuard.enabled has no effect.No webhook, README.md, or DEVELOPMENT.md changes. Existing deployments are not actively uninstalled.
Validation
go test ./...golangci-lint run ./cmd/fetcher/... ./pkg/apis/operator/... ./pkg/reconciler/knativeserving/...(0 issues)git diff --check upstream/main...HEADNo cluster E2E tests were run.