Skip to content

Remove Security Guard integration from the Operator - #2366

Open
dprotaso wants to merge 5 commits into
mainfrom
dprotaso/security-guard-noop
Open

dprotaso wants to merge 5 commits into
mainfrom
dprotaso/security-guard-noop

Conversation

@dprotaso

@dprotaso dprotaso commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Remove the retired alpha Security Guard integration for Operator v1.25, tracked in knative/community#1802.

Rebased onto main. The v1.24 compatibility fix in #2367 has merged into release-1.24; this removal targets main only and includes the warning/status handling that is not present on main.

  • Remove installation, transformations, version mappings, fetching, bundled manifests, dedicated Guardian RBAC, and obsolete tests/fixtures.
  • Keep the API field accepted but ignored for every target Serving version, and document this in the CRD schema.
  • Include SecurityGuardDeprecated warning/status handling with the message: Security Guard is no longer supported. spec.security.securityGuard.enabled has no effect.
  • Clear the condition when disabled or absent and keep it independent of readiness.
  • Cover warning lifecycle and reconciliation in existing test files; do not add new test files.

No webhook, README.md, or DEVELOPMENT.md changes. Existing deployments are not actively uninstalled.

Validation

  • go test ./...
  • golangci-lint run ./cmd/fetcher/... ./pkg/apis/operator/... ./pkg/reconciler/knativeserving/... (0 issues)
  • git diff --check upstream/main...HEAD

No cluster E2E tests were run.

Security Guard support has been removed. spec.security.securityGuard.enabled remains accepted but has no effect for any target Serving version. The SecurityGuardDeprecated status message reflects the removal; disabling the field clears the warning.

@knative-prow knative-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2026
@knative-prow
knative-prow Bot requested review from aliok and matzew November 1, 2026 18:00
@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2026
@dprotaso dprotaso changed the title Retire Security Guard for Serving v1.25 and later [WIP] Retire Security Guard for Serving v1.25 and later Nov 1, 2026
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2026
@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.32%. Comparing base (33b3be4) to head (ee20751).

Files with missing lines Patch % Lines
.../apis/operator/v1beta1/knativeserving_lifecycle.go 83.33% 2 Missing ⚠️
cmd/fetcher/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
- Coverage   66.39%   66.32%   -0.07%     
==========================================
  Files          56       54       -2     
  Lines        2693     2646      -47     
==========================================
- Hits         1788     1755      -33     
+ Misses        772      763       -9     
+ Partials      133      128       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso dprotaso changed the title [WIP] Retire Security Guard for Serving v1.25 and later Remove Security Guard integration from the Operator Nov 1, 2026
@knative-prow knative-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2026
@dprotaso

dprotaso commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

/retest

@dprotaso

dprotaso commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Companion release-1.24 fix and advance deprecation notice: #2367. This PR now clears the v1.24 SecurityGuardDeprecated condition on upgrade, replacing it with SecurityGuardIgnored when enabled (and clearing it when disabled).

@dprotaso
dprotaso force-pushed the dprotaso/security-guard-noop branch from ee20751 to ded9aeb Compare November 2, 2026 00:35
@dprotaso dprotaso changed the title Remove Security Guard integration from the Operator WIP: Remove Security Guard integration from the Operator Nov 2, 2026
@dprotaso
dprotaso changed the base branch from main to dprotaso/fix-security-guard-1.24 November 2, 2026 00:35
@dprotaso
dprotaso marked this pull request as draft November 2, 2026 00:35
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2026
@dprotaso
dprotaso force-pushed the dprotaso/security-guard-noop branch from ded9aeb to dd603c1 Compare November 2, 2026 00:39
@knative-prow

knative-prow Bot commented Nov 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
dprotaso force-pushed the dprotaso/security-guard-noop branch 2 times, most recently from 0001e24 to 404f320 Compare November 2, 2026 00:44
@dprotaso
dprotaso force-pushed the dprotaso/security-guard-noop branch from 7e9d9cf to 9325150 Compare November 3, 2026 03:09
@dprotaso
dprotaso changed the base branch from dprotaso/fix-security-guard-1.24 to main November 3, 2026 03:10
@dprotaso
dprotaso marked this pull request as ready for review November 3, 2026 03:10
@dprotaso dprotaso changed the title WIP: Remove Security Guard integration from the Operator Remove Security Guard integration from the Operator Nov 3, 2026
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2026
@dprotaso

dprotaso commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

/hold

for review

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants