Skip to content

pull configmap parsing into separate package#3185

Merged
knative-prow[bot] merged 3 commits intoknative:mainfrom
dprotaso:configmap-refactor
Jun 12, 2025
Merged

pull configmap parsing into separate package#3185
knative-prow[bot] merged 3 commits intoknative:mainfrom
dprotaso:configmap-refactor

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 11, 2025

We want to parse configmaps but don't want a heavy dependency on k/k libs

Part of knative/serving#9957

This will matter as a part of the OTel migration - since we will want to parse the config in the queue-proxy

We want to parse these configmaps but not don't want a heavy dependency on k/k libs
@knative-prow knative-prow Bot requested review from Leo6Leo and aslom June 11, 2025 21:10
@knative-prow knative-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2025
@dprotaso dprotaso force-pushed the configmap-refactor branch from ec53048 to 41398b8 Compare June 11, 2025 21:14
@dprotaso
Copy link
Copy Markdown
Member Author

/assign @Fedosin @skonto @dsimansk

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.53%. Comparing base (4e27b2e) to head (2237728).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   75.54%   75.53%   -0.01%     
==========================================
  Files         191      192       +1     
  Lines       11192    11164      -28     
==========================================
- Hits         8455     8433      -22     
+ Misses       2479     2475       -4     
+ Partials      258      256       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Copy Markdown
Member Author

TestMetricsExport flake

/test unit-tests_pkg_main

Copy link
Copy Markdown
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 05e18ff into knative:main Jun 12, 2025
29 of 39 checks passed
@dprotaso dprotaso deleted the configmap-refactor branch June 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants