-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set k8s default container label #15694
base: main
Are you sure you want to change the base?
Conversation
Welcome @konstfish! It looks like this is your first PR to knative/serving 🎉 |
Hi @konstfish. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: konstfish The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some more notes on this, I was unsure if I should put this behind some sort of feature gate, but I'd be happy to as about ~12 tests were affected by these changes. Fix for now was just to include the extra annotation in the want (in https://github.com/knative/serving/pull/15694/files#diff-d93eacd83502ff2061608160378ff8c5c8b199fed97cd44e2b1ab73f419b9aab & https://github.com/knative/serving/pull/15694/files#diff-508e07fc6207ae8956d33f7753a1407b85885edff3135849635263501ed77fd5) but I feel like this isn't really the cleanest solution. Would love some feedback on that! |
Fixes #15391
Proposed Changes
kubectl.kubernetes.io/default-container
annotation to Pods, pointing to the user-container. This ensures kubectl will always select the correct pod by default when interacting withkubectl logs
,kubectl exec
, etc.Release Note