Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set k8s default container label #15694

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

konstfish
Copy link

Fixes #15391

Proposed Changes

  • Add the kubectl.kubernetes.io/default-container annotation to Pods, pointing to the user-container. This ensures kubectl will always select the correct pod by default when interacting with kubectl logs, kubectl exec, etc.

Release Note

Add default container annotation to Pods created by the reconciler

Copy link

linux-foundation-easycla bot commented Jan 14, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from izabelacg and skonto January 14, 2025 13:36
Copy link

knative-prow bot commented Jan 14, 2025

Welcome @konstfish! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2025
Copy link

knative-prow bot commented Jan 14, 2025

Hi @konstfish. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: konstfish
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@konstfish
Copy link
Author

Some more notes on this, I was unsure if I should put this behind some sort of feature gate, but I'd be happy to as about ~12 tests were affected by these changes. Fix for now was just to include the extra annotation in the want (in https://github.com/knative/serving/pull/15694/files#diff-d93eacd83502ff2061608160378ff8c5c8b199fed97cd44e2b1ab73f419b9aab & https://github.com/knative/serving/pull/15694/files#diff-508e07fc6207ae8956d33f7753a1407b85885edff3135849635263501ed77fd5) but I feel like this isn't really the cleanest solution. Would love some feedback on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set k8s default container label
1 participant