Skip to content

[release-1.20] Suppress 'default value insecure' warning when secure-pod-defaults is enabled. #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.20
Choose a base branch
from
Open

[release-1.20] Suppress 'default value insecure' warning when secure-pod-defaults is enabled. #16220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/serving/k8s_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ func warnDefaultContainerSecurityContext(ctx context.Context, psc *corev1.PodSec
}

// if the user has explicitly enabled the feature, we don't need to warn
if slices.Contains([]config.Flag{config.Enabled, config.AllowRootBounded}, config.FromContextOrDefaults(ctx).Features.PodSpecSecurityContext) {
if slices.Contains([]config.Flag{config.Enabled, config.AllowRootBounded}, config.FromContextOrDefaults(ctx).Features.SecurePodDefaults) {
return nil
}

Expand Down
50 changes: 50 additions & 0 deletions pkg/apis/serving/k8s_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,20 @@ func withPodSpecSecurityContextEnabled() configOption {
}
}

func withSecurePodDefaultsEnabled() configOption {
return func(cfg *config.Config) *config.Config {
cfg.Features.SecurePodDefaults = config.Enabled
return cfg
}
}

func withSecurePodDefaultsAllowRootBounded() configOption {
return func(cfg *config.Config) *config.Config {
cfg.Features.SecurePodDefaults = config.AllowRootBounded
return cfg
}
}

func withContainerSpecAddCapabilitiesEnabled() configOption {
return func(cfg *config.Config) *config.Config {
cfg.Features.ContainerSpecAddCapabilities = config.Enabled
Expand Down Expand Up @@ -847,6 +861,42 @@ func TestPodSpecValidation(t *testing.T) {
},
want: apis.ErrInvalidValue("all", "containers[0].securityContext.capabilities.drop", "Must be spelled as 'ALL'").At(apis.WarningLevel),
errLevel: apis.WarningLevel,
}, {
name: "no warnings when SecurePodDefaults is enabled",
ps: corev1.PodSpec{
Containers: []corev1.Container{{
Image: "busybox",
}},
},
cfgOpts: []configOption{withSecurePodDefaultsEnabled()},
want: nil,
errLevel: apis.WarningLevel,
}, {
name: "no warnings when SecurePodDefaults is AllowRootBounded",
ps: corev1.PodSpec{
Containers: []corev1.Container{{
Image: "busybox",
}},
},
cfgOpts: []configOption{withSecurePodDefaultsAllowRootBounded()},
want: nil,
errLevel: apis.WarningLevel,
}, {
name: "no warnings when SecurePodDefaults enabled with incomplete security context",
ps: corev1.PodSpec{
Containers: []corev1.Container{{
Image: "busybox",
SecurityContext: &corev1.SecurityContext{
Capabilities: &corev1.Capabilities{},
},
}},
SecurityContext: &corev1.PodSecurityContext{
SeccompProfile: &corev1.SeccompProfile{},
},
},
cfgOpts: []configOption{withSecurePodDefaultsEnabled()},
want: nil,
errLevel: apis.WarningLevel,
}}

for _, test := range tests {
Expand Down
Loading