Add terminationGracePeriodSeconds support to user and sidecar container probes (#15823)

[flomedja]

Fixes #

#15823

Proposed Changes

Add terminationGracePeriodSeconds in the probe Mask used for the container probes. This will allw it to be configurable for the container probes. I add the issue #16256 to validate the the startup probes for user and sidecar containers.

Release Note

• Add terminationGracePeriodSeconds support for user and sidecar container probes

[knative-prow]

Hi @flomedja. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flomedja
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.07%. Comparing base (f3a653f) to head (ebeeacb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16255      +/-   ##
==========================================
+ Coverage   80.03%   80.07%   +0.04%     
==========================================
  Files         215      215              
  Lines       13327    13328       +1     
==========================================
+ Hits        10666    10673       +7     
+ Misses       2300     2295       -5     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[flomedja]

@dsimansk @skonto Can you help to rerun the failed e2e test ?

[linkvt]

/retest

[linkvt]

/ok-to-test